Add missing attrs / correct bad attrs on TaskInstancePydantic #37854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstandish
force-pushed
the
missing-or-wrong-attrs-on-task-instance-pydantic
branch
from
af550aa
to
be054bd
Compare
potiuk
approved these changes
Mar 3, 2024
dirrao
suggested changes
Mar 3, 2024
dstandish
force-pushed
the
missing-or-wrong-attrs-on-task-instance-pydantic
branch
2 times, most recently
from
4df2c2c
to
b48f44e
Compare
uranusjr
reviewed
Mar 5, 2024
dstandish
force-pushed
the
missing-or-wrong-attrs-on-task-instance-pydantic
branch
2 times, most recently
from
b8f5f2e
to
a8be0cd
Compare
eladkal
approved these changes
Mar 17, 2024
dstandish
force-pushed
the
missing-or-wrong-attrs-on-task-instance-pydantic
branch
from
a8be0cd
to
588519b
Compare
|
ok @uranusjr @potiuk @eladkal ... In response to the question "why do we need to add defaults to pydantic".... I have have added a default of None to attr this isn't really a straightforward change because (1) mypy doesn't like it and, more importantly, (2) there is logic in airflow that looks at can you take a look and let me know what you think is the better approach? i.e. should we proceed with the changes i've just made, or go back and stick with just adding a default on the pydantic model. |
dstandish
force-pushed
the
missing-or-wrong-attrs-on-task-instance-pydantic
branch
from
51c3316
to
402c436
Compare
dstandish
requested review from
o-nikolas,
pierrejeambrun and
hussein-awala
as code owners
One was wrong type; others were missing; others needed a default.
dstandish
force-pushed
the
missing-or-wrong-attrs-on-task-instance-pydantic
branch
from
2c520d1
to
b8d4b35
Compare
vincbeck
approved these changes
Mar 19, 2024
utkarsharma2
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 22, 2024
…antic (apache#37854) This was motivated by the need to fix serialization of TaskInstance to TaskInstancePydantic. In some cases the data type was wrong; in other cases the attr was missing. In the case of `task` it was more complicated. Historically the value is type-declared but not set at init. So it's not alway there. And in the code base there was a lot of hasattr... The problem here though was that when serializing to TaskInstancePydantic, if the value was not set, then serialization would fail. So we had to make it optional on TaskInstance and provide a default of None.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One was wrong type; others were missing; others needed a default.