Reduce s3hook memory usage #37886
Merged
Reduce s3hook memory usage #37886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon-aws
If we think it's right to remove we can introduce a breaking change release. |
vincbeck
approved these changes
Mar 4, 2024
Taragolis
reviewed
Mar 4, 2024
ferruzzi
approved these changes
Mar 4, 2024
dirrao
approved these changes
Mar 5, 2024
As far a I could see this PR do not replace boto3.resource by a boto3.client, in general it should reduce a bit of memory usage |
o-nikolas
approved these changes
Mar 5, 2024
Taragolis
approved these changes
Mar 6, 2024
howardyoo
pushed a commit
to howardyoo/airflow
that referenced
this pull request
Mar 18, 2024
utkarsharma2
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #35449
Cached an S3 resource property for functions still using resources. Ran a simple loop of hook.get_bucket() for 5 buckets and captured memory data with memray. Memory usage went from 34.5mb without caching to 11.5mb with cached property. This PR doesn't address removing the use of Resources, since it would cause a breaking change for anyone directly calling
hook.get_bucket()orhook.get_key().Cleaned up some of the other typing code and imports.