-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix side-effect of default options in Beam Operators #37916
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the operators in Apache Beam had side effect that they modified detault options passed to it in constructor, and in case of xdist tests it had side effect that they could impact other test results (this happened recently in main). The default options are already set by the Dataflow mixin in execute method in all Beam operators, but in Python and Go operator the defaults are also set in the constructor. Setting the defaults in mixin uses deepcopy to avoid such side effects. This might be intended, so this PR rather than removing default settings in the constructor, also adds deepcopy in them and fixes resulting tests - removing the defaults in tests that do not have the defaults set in the constructor.
vincbeck
approved these changes
Mar 5, 2024
jscheffl
approved these changes
Mar 5, 2024
Taragolis
reviewed
Mar 5, 2024
Taragolis
approved these changes
Mar 5, 2024
So - ideally - we could likely remove if we are sure it's fine, but even if we could, it should be a separate PR IMHO.
|
Yeah, all logic around templated_fields should be moved into the |
utkarsharma2
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 22, 2024
Some of the operators in Apache Beam had side effect that they modified detault options passed to it in constructor, and in case of xdist tests it had side effect that they could impact other test results (this happened recently in main). The default options are already set by the Dataflow mixin in execute method in all Beam operators, but in Python and Go operator the defaults are also set in the constructor. Setting the defaults in mixin uses deepcopy to avoid such side effects. This might be intended, so this PR rather than removing default settings in the constructor, also adds deepcopy in them and fixes resulting tests - removing the defaults in tests that do not have the defaults set in the constructor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the operators in Apache Beam had side effect that they modified detault options passed to it in constructor, and in case of xdist tests it had side effect that they could impact other test results (this happened recently in main). The default options are already set by the Dataflow mixin in execute method in all Beam operators, but in Python and Go operator the defaults are also set in the constructor.
Setting the defaults in mixin uses deepcopy to avoid such side effects.
This might be intended, so this PR rather than removing default settings in the constructor, also adds deepcopy in them and fixes resulting tests - removing the defaults in tests that do not have the defaults set in the constructor.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.