-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore delegate_to for Google Transfer Operators retrieving from Google Cloud. #37925
Restore delegate_to for Google Transfer Operators retrieving from Google Cloud. #37925
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
ff5368e
to
c6196cf
Compare
cc: @VladaZakharova ? |
af6387d
to
4afaf1f
Compare
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
…gle Cloud. (apache#37925) * Restore delegate_to for Google Transfer Operators retrieving from Google Cloud. * Add newsfragment
…gle Cloud. (apache#37925) * Restore delegate_to for Google Transfer Operators retrieving from Google Cloud. * Add newsfragment
…gle Cloud. (apache#37925) * Restore delegate_to for Google Transfer Operators retrieving from Google Cloud. * Add newsfragment
This PR restores the
delegate_to
parameter to Transfer Operators moving Google Cloud data to Google Drive removed when addressing #29088 via #30748.The
delgate_to
parameter provides Google Suite Hooks a method of interacting with user spaces, as service accounts are not able to interact with user owned spaces with implicit permissions. While it makes sense thatdelegate_to
has been deprecated in favour ofimpersonation_chain
for the Google Cloud Hooks, I suspect this was removed in error from GoogleDriveHooks in Transfer Operators that also include Google Cloud Hooks. Google Drive Hooks and Transfer Operators that do not involve Google Cloud still supports thedelegate_to
parameter, so it make sense that the Transfer operators copying from Google Cloud into Google Drive do as well.This PR contains the following changes:
delegate_to
argument only applies to the GoogleDrive hooks.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.