Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore delegate_to for Google Transfer Operators retrieving from Google Cloud. #37925

Conversation

emery-finkelstein
Copy link
Contributor

This PR restores the delegate_to parameter to Transfer Operators moving Google Cloud data to Google Drive removed when addressing #29088 via #30748.

The delgate_to parameter provides Google Suite Hooks a method of interacting with user spaces, as service accounts are not able to interact with user owned spaces with implicit permissions. While it makes sense that delegate_to has been deprecated in favour of impersonation_chain for the Google Cloud Hooks, I suspect this was removed in error from GoogleDriveHooks in Transfer Operators that also include Google Cloud Hooks. Google Drive Hooks and Transfer Operators that do not involve Google Cloud still supports the delegate_to parameter, so it make sense that the Transfer operators copying from Google Cloud into Google Drive do as well.

This PR contains the following changes:

  • Adds delegate_to as constructor arguments and instance variables for GCSToGoogleDrive and GCSToGoogleSheets Transfer operators.
  • Adds appropriate unittest coverage.
  • Updates inline documentation for these classes to explicitly note that the delegate_to argument only applies to the GoogleDrive hooks.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Mar 6, 2024
Copy link

boring-cyborg bot commented Mar 6, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@emery-finkelstein emery-finkelstein marked this pull request as ready for review March 6, 2024 04:02
@emery-finkelstein emery-finkelstein force-pushed the restore-delegate_to-for-Cloud-to-Drive-transfer-operators branch from ff5368e to c6196cf Compare March 6, 2024 04:03
@potiuk
Copy link
Member

potiuk commented Mar 6, 2024

cc: @VladaZakharova ?

@emery-finkelstein emery-finkelstein force-pushed the restore-delegate_to-for-Cloud-to-Drive-transfer-operators branch from af6387d to 4afaf1f Compare March 7, 2024 23:19
@potiuk potiuk merged commit e256bad into apache:main Mar 8, 2024
55 checks passed
Copy link

boring-cyborg bot commented Mar 8, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Mar 14, 2024
howardyoo pushed a commit to howardyoo/airflow that referenced this pull request Mar 18, 2024
…gle Cloud. (apache#37925)

* Restore delegate_to for Google Transfer Operators retrieving from Google Cloud.

* Add newsfragment
howardyoo pushed a commit to howardyoo/airflow that referenced this pull request Mar 31, 2024
…gle Cloud. (apache#37925)

* Restore delegate_to for Google Transfer Operators retrieving from Google Cloud.

* Add newsfragment
utkarsharma2 pushed a commit to astronomer/airflow that referenced this pull request Apr 22, 2024
…gle Cloud. (apache#37925)

* Restore delegate_to for Google Transfer Operators retrieving from Google Cloud.

* Add newsfragment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants