Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reduce irrelevant error logs for pod events. #37944

Merged
merged 1 commit into from
Mar 7, 2024
Merged

fix: reduce irrelevant error logs for pod events. #37944

merged 1 commit into from
Mar 7, 2024

Conversation

sudiptob2
Copy link
Contributor

@sudiptob2 sudiptob2 commented Mar 6, 2024 •
edited
Loading

fixes #36077

Kubernetes pod Event API provides type i.e. Warning and Normal. It is possible to log event failures into different log levels using this type attribute.
Ref: https://kubernetes.io/docs/reference/kubernetes-api/cluster-resources/event-v1/

Initial testing gives following output:
Test Dag: test_fail_dag_2
Output:
image

@boring-cyborg boring-cyborg bot added area:providers provider:cncf-kubernetes Kubernetes provider related issues labels Mar 6, 2024
@sudiptob2 sudiptob2 marked this pull request as ready for review March 6, 2024 19:18
@sudiptob2 sudiptob2 mentioned this pull request Mar 6, 2024
Closed
2 tasks
@potiuk
Copy link
Member

potiuk commented Mar 6, 2024

Looks good. Two comments:

  • can you please rebase
  • can you plesed add a unit test for that one ?

@sudiptob2 sudiptob2 force-pushed the fix/k8s-irrelevant-logs branch 2 times, most recently from 226f58b to b456308 Compare March 6, 2024 21:38
@sudiptob2 sudiptob2 changed the title fix: reduce error irrelevant error logs for pod events. fix: reduce irrelevant error logs for pod events. Mar 6, 2024
@sudiptob2
Copy link
Contributor Author

@potiuk thanks for looking at the PR.

  • can you plesed add a unit test for that one ?

Added a unit test.

@ketozhang
Copy link
Contributor

Looks good to me, nice work!

@potiuk potiuk merged commit a7b7928 into apache:main Mar 7, 2024
55 checks passed
@sudiptob2 sudiptob2 deleted the fix/k8s-irrelevant-logs branch March 7, 2024 15:11
howardyoo pushed a commit to howardyoo/airflow that referenced this pull request Mar 18, 2024
@sudiptob2 @howardyoo
fix: reduce irrelevant error logs for pod events. (apache#37944)
5a170d3 
Signed-off-by: sudipto baral <[email protected]>
howardyoo pushed a commit to howardyoo/airflow that referenced this pull request Mar 31, 2024
@sudiptob2 @howardyoo
fix: reduce irrelevant error logs for pod events. (apache#37944)
34f45f1 
Signed-off-by: sudipto baral <[email protected]>
@eladkal eladkal mentioned this pull request Apr 10, 2024
Closed
utkarsharma2 pushed a commit to astronomer/airflow that referenced this pull request Apr 22, 2024
@sudiptob2 @utkarsharma2
fix: reduce irrelevant error logs for pod events. (apache#37944)
7d84c1e 
Signed-off-by: sudipto baral <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potiuk potiuk potiuk approved these changes

@jedcunningham jedcunningham Awaiting requested review from jedcunningham jedcunningham is a code owner

@hussein-awala hussein-awala Awaiting requested review from hussein-awala hussein-awala is a code owner

Assignees
No one assigned
Labels
area:providers provider:cncf-kubernetes Kubernetes provider related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce irrelevant ERROR level logs from KubernertesPodOperator on pod runtime failure
3 participants
@sudiptob2 @potiuk @ketozhang