-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: EmrServerlessStartJobOperator not serializing DAGs correctly whe… #38022
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is looks fine, however I would rather get rid of conditional Extra Link which implemented by the propery method. It has a bugs into the BatchOperator into the past, and now it happen into the EmrServerlessStartJobOperator
Better link would be grey-out rather than every time try to fix it. But it could be done into the separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like there has got to be a cleaner way to do this and I came up with a couple alternatives, but none that are significantly better. I'll approve, but hopefully someone comes up with a DRYer solution.
97948a4
to
d0e30b4
Compare
class AwesomeOperator:
operator_extra_links = (Link1(), Link2(),) |
845faeb
to
442ce77
Compare
…n partial/expand is used.
442ce77
to
95fd866
Compare
…n partial/expand is used. (apache#38022)
This fixes: #38005
Result: Now EMRServerlessStartJobOperator is able to utilize partial/expand functionality of Airflow.
Previously, the following DAG code will fail to serialize in the webserver:
After this PR, the above DAG should be serialized successfully.