Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SparkSqlOperator's field to comply with templated fields' validation #38045

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

shahar1
Copy link
Contributor

@shahar1 shahar1 commented Mar 11, 2024

related: #36484


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@shahar1 shahar1 force-pushed the rename-sparkoperator-field branch 2 times, most recently from 7bbec7c to 99c7c8b Compare March 11, 2024 19:05
@shahar1 shahar1 marked this pull request as draft March 11, 2024 19:28
@shahar1 shahar1 marked this pull request as ready for review March 11, 2024 19:30
Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The _sql is there since the operator was added in #1644
I didn't find any reason why it should be declared as private.

LGTM

@eladkal eladkal merged commit 58bffa6 into apache:main Mar 12, 2024
55 checks passed
@shahar1 shahar1 deleted the rename-sparkoperator-field branch March 12, 2024 20:48
drajguru pushed a commit to drajguru/airflow that referenced this pull request Mar 14, 2024
@shahar1 shahar1 restored the rename-sparkoperator-field branch March 15, 2024 12:24
howardyoo pushed a commit to howardyoo/airflow that referenced this pull request Mar 18, 2024
howardyoo pushed a commit to howardyoo/airflow that referenced this pull request Mar 31, 2024
utkarsharma2 pushed a commit to astronomer/airflow that referenced this pull request Apr 22, 2024
@shahar1 shahar1 deleted the rename-sparkoperator-field branch June 12, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants