Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename DeleteCustomTrainingJobOperator's fields' names to comply with templated fields validation #38048

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

shahar1
Copy link
Contributor

@shahar1 shahar1 commented Mar 11, 2024

related: #36484


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:dev-tools area:providers provider:google Google (including GCP) related issues labels Mar 11, 2024
@shahar1
Copy link
Contributor Author

shahar1 commented Mar 12, 2024

@eladkal / @Taragolis ready for your review

Copy link
Contributor

@Taragolis Taragolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine, just so minor suggestion about test templates

tests/providers/google/cloud/operators/test_vertex_ai.py Outdated Show resolved Hide resolved
@shahar1 shahar1 force-pushed the rename-custom-job-fields branch 2 times, most recently from e2ecb0d to 633ed73 Compare March 15, 2024 05:55
Co-authored-by: Andrey Anshin <[email protected]>

Rename `DeleteCustomTrainingJobOperator`'s fields' name to comply with templated fields validation
@eladkal eladkal merged commit 83060e1 into apache:main Mar 15, 2024
52 checks passed
@shahar1 shahar1 deleted the rename-custom-job-fields branch March 15, 2024 12:06
utkarsharma2 pushed a commit to astronomer/airflow that referenced this pull request Apr 22, 2024
…th templated fields validation (apache#38048)

Co-authored-by: Andrey Anshin <[email protected]>

Rename `DeleteCustomTrainingJobOperator`'s fields' name to comply with templated fields validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools area:providers provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants