Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename DatabricksSqlOperator's fields' names to comply with templated fields validation #38052

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

shahar1
Copy link
Contributor

@shahar1 shahar1 commented Mar 11, 2024

related: #36484


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@shahar1 shahar1 marked this pull request as draft March 11, 2024 21:23
@shahar1 shahar1 force-pushed the rename-databricks-sql-fields branch from 7e07280 to 431c95d Compare March 11, 2024 21:32
@shahar1 shahar1 marked this pull request as ready for review March 11, 2024 21:32
@shahar1 shahar1 force-pushed the rename-databricks-sql-fields branch from 431c95d to d76a2d2 Compare March 11, 2024 22:22
Copy link
Collaborator

@dirrao dirrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this change backward compatible?

@shahar1 shahar1 force-pushed the rename-databricks-sql-fields branch from d76a2d2 to 762e719 Compare March 12, 2024 22:35
@shahar1
Copy link
Contributor Author

shahar1 commented Mar 12, 2024

is this change backward compatible?

Yes, added a test to validate it

@shahar1 shahar1 requested a review from dirrao March 12, 2024 22:36
@shahar1 shahar1 force-pushed the rename-databricks-sql-fields branch from 762e719 to e131758 Compare March 15, 2024 06:50
@eladkal eladkal force-pushed the rename-databricks-sql-fields branch from e131758 to ceb9e25 Compare March 15, 2024 13:23
@eladkal eladkal merged commit 4742fc0 into apache:main Mar 15, 2024
52 checks passed
utkarsharma2 pushed a commit to astronomer/airflow that referenced this pull request Apr 22, 2024
@shahar1 shahar1 deleted the rename-databricks-sql-fields branch June 12, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants