Update SqlToSlackApiFileOperator with new param to check empty output #38079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirrao
reviewed
Mar 12, 2024
eladkal
reviewed
Mar 12, 2024
Taragolis
reviewed
Mar 12, 2024
andyguwc
force-pushed
the
tianyou/slack-file-operator
branch
from
a29bdf6
to
012fc39
Compare
Taragolis
reviewed
Mar 14, 2024
andyguwc
force-pushed
the
tianyou/slack-file-operator
branch
2 times, most recently
from
1f5ea1f
to
c49f8e0
Compare
eladkal
changed the title
fmt: make formatting changes Co-authored-by: Andrey Anshin <[email protected]>
andyguwc
force-pushed
the
tianyou/slack-file-operator
branch
from
c49f8e0
to
1d4d180
Compare
Taragolis
approved these changes
Mar 18, 2024
utkarsharma2
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 22, 2024
…apache#38079) * fix: Update SqlToSlackApiFileOperator with new param to check empty output * fix: skip sending slack instead of raising exception * fix: update param to allow different ways to handle an empty df * Apply suggestions from code review fmt: make formatting changes Co-authored-by: Andrey Anshin <[email protected]> --------- Co-authored-by: Andrey Anshin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new param to the SqlToSlackApiFileOperator to optionally allow skipping sending an empty file.
closes: #37191
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.