-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update log level to debug from warning about scheduled_duration metric #38180
Conversation
@kzosabe Is there a chance this will be merged in the next release? |
@gil-tober I hope it will, but I don't have the authority to decide that. |
Yes. It's very bad to keep you in a limbo like that especially after all the attempt you've made @kzosabe . Apologies for that in the name of all other maintainers. You seem to have a valid annoying issue that we generally avoided to handle. I have no idea if it is right or wrong. This all seems from the implementation in #30612 and it seem to be somewhat broken anyway as indicated in #30612 (comment) and PR to likely fix some of that in #37936. Maybe @vandonr as the original author can chime in an comment on those. Seem that none of the other maintainers involved in the past discussions have picked up the discussion, but It's lkely better to avoid harm even if the discussion is not finished (cc: @hussein-awala @uranusjr). I will ping them to see if they can be fixed in the original PRs, but for now I see no harm at all to change that warning into a debug mode. Happy to accept the change for 2.9.0, but: a) please change it to debug. Please ping me when it's done and I will merge it. |
Yup agreed with changing it to Debug in the meantime |
Co-authored-by: Wei Lee <[email protected]>
Random failure. Merging. |
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
…ic (#38180) --------- Co-authored-by: Tzu-ping Chung <[email protected]> Co-authored-by: Wei Lee <[email protected]> (cherry picked from commit b9e96df)
…ic (apache#38180) --------- Co-authored-by: Tzu-ping Chung <[email protected]> Co-authored-by: Wei Lee <[email protected]>
…ic (apache#38180) --------- Co-authored-by: Tzu-ping Chung <[email protected]> Co-authored-by: Wei Lee <[email protected]>
closes: #34493
The previous PR (#34771) is stuck due to the complexity of the problem.
This incorrect warning is causing inconvenience to users, so we will make a change to stop it first.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.