Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cosmos hook static checks by making providing partition_key mandatory #38199

Merged
merged 7 commits into from
Apr 10, 2024

Conversation

hussein-awala
Copy link
Member

@hussein-awala hussein-awala commented Mar 16, 2024

closes: #38196

According to Azure/azure-sdk-for-python#34795 (comment) we cannot create non-partitioned cosmos collections anymore, this is badly handled in the Python SDK but we will receive an API exception if we try to do that.

I update the PR to make the partition_key mandatory, with the possibility to define a default one in the connection.

@potiuk
Copy link
Member

potiuk commented Mar 16, 2024

Nice :). Airflow detecting and spreading fixes to hundreds of libraries :)

Copy link
Collaborator

@dirrao dirrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cosmos related test cases are failing.

@hussein-awala
Copy link
Member Author

Cosmos related test cases are failing.

Check the PR description, it depends on another PR that fixes the issue in the microsoft sdk.

@hussein-awala hussein-awala changed the title Remove cosmos upper bound version and fix type annotations fix cosmos hook static checks by making providing partition_key mandatory Apr 1, 2024
@hussein-awala
Copy link
Member Author

@eladkal I updated the PR and its description according to azure python SDK maintainers, could you check if we can consider it as a bug fix or if we need a new major release? Do I need to add something to changelog?

@eladkal eladkal self-requested a review April 1, 2024 17:49
@eladkal
Copy link
Contributor

eladkal commented Apr 4, 2024

@eladkal I updated the PR and its description according to azure python SDK maintainers, could you check if we can consider it as a bug fix or if we need a new major release? Do I need to add something to changelog?

I don't think it qualify as breaking but the next release is major due to another PR so we can treat this one as major change in terms of the entry log.

Simply add the needed explnation for users on the 1.10 entry of the change log

@hussein-awala hussein-awala merged commit 768e116 into apache:main Apr 10, 2024
92 checks passed
utkarsharma2 pushed a commit to astronomer/airflow that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve mypy violations for azure-cosmos >= 4.6.0
4 participants