Fix dynamic allocation specs handling for custom launcher #38223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudohainguyen
requested review from
jedcunningham and
hussein-awala
as code owners
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
dirrao
reviewed
Mar 17, 2024
tests/providers/cncf/kubernetes/operators/test_custom_object_launcher.py
Outdated
Show resolved
Hide resolved
Taragolis
reviewed
Mar 17, 2024
tests/providers/cncf/kubernetes/operators/test_custom_object_launcher.py
Outdated
Show resolved
Hide resolved
tests/providers/cncf/kubernetes/operators/test_custom_object_launcher.py
Outdated
Show resolved
Hide resolved
tests/providers/cncf/kubernetes/operators/test_custom_object_launcher.py
Outdated
Show resolved
Hide resolved
sudohainguyen
force-pushed
the
cncf/unittest
branch
from
88a0a9a
to
c82d9ea
Compare
sudohainguyen
changed the title
sudohainguyen
force-pushed
the
cncf/unittest
branch
from
597ff6b
to
87cec6b
Compare
Taragolis
approved these changes
Mar 17, 2024
sudohainguyen
force-pushed
the
cncf/unittest
branch
from
659702e
to
5e199cc
Compare
eladkal
approved these changes
Mar 18, 2024
Signed-off-by: Hai Nguyen <[email protected]>
Signed-off-by: Hai Nguyen <[email protected]>
Signed-off-by: Hai Nguyen <[email protected]>
Signed-off-by: Hai Nguyen <[email protected]>
hamedhsn
approved these changes
Mar 18, 2024
utkarsharma2
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 22, 2024
* Add unit test for Spark Kubernetes custom launcher Signed-off-by: Hai Nguyen <[email protected]> * Test on cloned entries correctly Signed-off-by: Hai Nguyen <[email protected]> * Fix lint issue Signed-off-by: Hai Nguyen <[email protected]> * Move cloned entries declaration out of raise assertion scope Signed-off-by: Hai Nguyen <[email protected]> --------- Signed-off-by: Hai Nguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily about a fix to handle dynamicAllocation specs gracefully and adding unit test for custom object launcher.
Context:
When defining dynamic allocation specs, if users accidentally miss any required fields, currently we throw a
KeyErrorexception which looks confused. So that I've put a minor change to make the exception thrown should beAirflowExceptionwith a more meaningful error message.On the other hand, we also don't have unit test to cover some helper classes in
custom_object_launcher.py, this PR also includes a few simple test cases.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.