Fix failing MinSQLAlchemy test after moving sqlalchemy spec #38444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
commented
Mar 25, 2024
potiuk
force-pushed
the
fix-failing-sqlalchemy-test
branch
2 times, most recently
from
f933afc
to
3a71097
Compare
Ths MIN SQLACLHEMY test was based on retrieving sqlalchemy min version from pyproject.toml but since we moved it to hatch_build.py we should read it from there.
potiuk
force-pushed
the
fix-failing-sqlalchemy-test
branch
from
3a71097
to
fa1ec4c
Compare
|
Closed in favour of canary test in #38445 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ths MIN SQLACLHEMY test was based on retrieving sqlalchemy min version from pyproject.toml but since we moved it to hatch_build.py we should read it from there.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.