Refactor: Directly pass HttpOperator data
and json
arguments to requests and aiohttp params
#38512
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #37291
Both
requests
andaiohttp
deal with json and data arguments in the samemanner (https://requests.readthedocs.io/en/latest/api/#requests.post and https://docs.aiohttp.org/en/stable/client_reference.html#aiohttp.ClientSession.request), so it would be more transparent to simply pass these arguments
directly. I believe it is also a good choice to be transparent in this
direct usage because requests is a very popular HTTP library so most
people already know how these arguments are expected.
The
params
argument could also be introduced in the HttpOperator with the same goal.This PR was meant to address #37291 after seeing the discussion started here #37293 (comment)
The PR includes a breaking change.