Make placeholder of DbApiHook configurable in UI
#38528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ApiHook class so that the same logic can also be used with the JdbcHook
Taragolis
added
the
full tests needed
Taragolis
reviewed
Mar 27, 2024
…only purpose is to define a default SQL placeholder, the actual placeholder will always be retrieved through the property
# Conflicts: # tests/providers/common/sql/hooks/test_sql.py
eladkal
changed the title
placeholder of DbApiHook configurable in UI
eladkal
reviewed
Apr 4, 2024
Co-authored-by: Elad Kalif <[email protected]>
potiuk
approved these changes
Apr 5, 2024
eladkal
approved these changes
Apr 6, 2024
|
Thank you for merging this pull request, could someone have a look to check this one also please: #38707 |
odaneau-astro
pushed a commit
to odaneau-astro/airflow
that referenced
this pull request
Apr 8, 2024
* refactor: Moved placeholder property from OdbcHook class to parent DbApiHook class so that the same logic can also be used with the JdbcHook * refactor: Import BaseHook under type checking block * refactor: Marked test_placeholder_config_from_extra as a db test * refactor: Moved mock_conn from conftest to test_utils module under common sql * refactor: Removed unnecessary else statement in placeholder property * refactor: Default placeholder can be a class/static variable as it's only purpose is to define a default SQL placeholder, the actual placeholder will always be retrieved through the property * refactor: Updated sql test with changes from main * refactor: Reformatted test * Update airflow/providers/common/sql/hooks/sql.py Co-authored-by: Elad Kalif <[email protected]> * fix: Fixed name of constant SQL_PLACEHOLDERS being checked in placeholder property --------- Co-authored-by: David Blain <[email protected]> Co-authored-by: Elad Kalif <[email protected]>
utkarsharma2
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 22, 2024
* refactor: Moved placeholder property from OdbcHook class to parent DbApiHook class so that the same logic can also be used with the JdbcHook * refactor: Import BaseHook under type checking block * refactor: Marked test_placeholder_config_from_extra as a db test * refactor: Moved mock_conn from conftest to test_utils module under common sql * refactor: Removed unnecessary else statement in placeholder property * refactor: Default placeholder can be a class/static variable as it's only purpose is to define a default SQL placeholder, the actual placeholder will always be retrieved through the property * refactor: Updated sql test with changes from main * refactor: Reformatted test * Update airflow/providers/common/sql/hooks/sql.py Co-authored-by: Elad Kalif <[email protected]> * fix: Fixed name of constant SQL_PLACEHOLDERS being checked in placeholder property --------- Co-authored-by: David Blain <[email protected]> Co-authored-by: Elad Kalif <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the placeholder property logic from OdbcHook to DbApiHook.
We now encountered the same issue when using jdbc connections as we did back then in odbc connections where the placeholder should be ? instead of %. As OdbcHook and JdbcHook both inherit DbApiHook, I moved the property there so both classes can use same logic. Also moved test of placeholder property from OdbcHook to DbApiHook and did some refactoring so both tests can reuse same mocking function.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.