Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add repair_run support to DatabricksRunNowOperator in deferrable mode #38619

Conversation

Lee-W
Copy link
Member

@Lee-W Lee-W commented Mar 29, 2024


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@Lee-W Lee-W force-pushed the add-repair-run-support-to-databrick-run-now-op-in-deferrable-mode branch from a8e488b to b1eb14a Compare March 30, 2024 00:58
@Lee-W Lee-W changed the title add repair_run supporrt to DatabricksRunNowOperator in deferrable mode add repair_run support to DatabricksRunNowOperator in deferrable mode Mar 30, 2024
@Lee-W Lee-W marked this pull request as ready for review March 30, 2024 01:07
@Lee-W Lee-W force-pushed the add-repair-run-support-to-databrick-run-now-op-in-deferrable-mode branch from b1eb14a to 9f5f9c0 Compare March 30, 2024 01:27
Copy link
Collaborator

@dirrao dirrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the test cases when the repair_run is enabled?

@Lee-W Lee-W force-pushed the add-repair-run-support-to-databrick-run-now-op-in-deferrable-mode branch from 9f5f9c0 to 7a8dc37 Compare April 1, 2024 01:45
@Lee-W Lee-W requested a review from dirrao April 1, 2024 06:13
@Lee-W
Copy link
Member Author

Lee-W commented Apr 1, 2024

Can you add the test cases when the repair_run is enabled?

Sure. Just added a test case for it

@eladkal eladkal merged commit 39b684d into apache:main Apr 1, 2024
40 checks passed
idantepper pushed a commit to idantepper/airflow that referenced this pull request Apr 3, 2024
…apache#38619)

* feat(databricks): add repair_run supporrt to DatabricksRunNowOperator in deferrable mode

* test(databricks): add test case test_execute_complete_failure_and_repair_run
idantepper pushed a commit to idantepper/airflow that referenced this pull request Apr 3, 2024
…apache#38619)

* feat(databricks): add repair_run supporrt to DatabricksRunNowOperator in deferrable mode

* test(databricks): add test case test_execute_complete_failure_and_repair_run
mathiaHT pushed a commit to mathiaHT/airflow that referenced this pull request Apr 4, 2024
…apache#38619)

* feat(databricks): add repair_run supporrt to DatabricksRunNowOperator in deferrable mode

* test(databricks): add test case test_execute_complete_failure_and_repair_run
utkarsharma2 pushed a commit to astronomer/airflow that referenced this pull request Apr 22, 2024
…apache#38619)

* feat(databricks): add repair_run supporrt to DatabricksRunNowOperator in deferrable mode

* test(databricks): add test case test_execute_complete_failure_and_repair_run
@Lee-W Lee-W deleted the add-repair-run-support-to-databrick-run-now-op-in-deferrable-mode branch June 5, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants