Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/refactor azure synapse pipeline class #38723

Merged

Conversation

romsharon98
Copy link
Contributor

@romsharon98 romsharon98 commented Apr 3, 2024

This PR intends to:

Introduce BaseAzureSynapseClass as the parent class for better code maintainability in Azure Synapse Hooks.
The base class will manage the common connection form, enabling child classes to inherit and share this connection form while implementing individual functionalities.

Add managed identity support to DefaultAzureCredential.

redo stale PR: #36622


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@romsharon98 romsharon98 force-pushed the feature/refactor-azure-synapse-pipeline branch from 7d656f6 to ec418c0 Compare April 4, 2024 12:37
Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eladkal eladkal merged commit 901c3a6 into apache:main Apr 4, 2024
40 checks passed
utkarsharma2 pushed a commit to astronomer/airflow that referenced this pull request Apr 22, 2024
* redesign azure synapse pipeline

* add breaking change

* fix statics

* add breaking change

* change mapping

* change changelog

* fix provider.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants