Removing deprecated code in hive provider #38859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoghrajesh
requested review from
hussein-awala,
Taragolis and
eladkal
and removed request for
hussein-awala and
Taragolis
|
@eladkal do we need to add anything to changelog? |
yes we need to explain what is removed and how to migrate (usually some variation of the removed warning) |
|
Could you also update CHANGELOG.rst and mention what things are removed, what is an alternative (if exists) and what the end users should use instead: |
Taragolis
reviewed
Apr 9, 2024
eladkal
approved these changes
Apr 9, 2024
utkarsharma2
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 22, 2024
* Removing deprecated code in hive provider * fixing tests and removing property * removing some more tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we will be having a 8.0.0, taking an opportunity to remove deprecated hive code.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.