Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AIRFLOW-3089] Drop hard-coded url scheme in google auth redirect. #3919

Merged
merged 1 commit into from
Oct 12, 2018
Merged

[AIRFLOW-3089] Drop hard-coded url scheme in google auth redirect. #3919

merged 1 commit into from
Oct 12, 2018

Commits on Oct 11, 2018

  1. [AIRFLOW-3089] Drop hard-coded url scheme in google auth redirect. 

    The google auth provider hard-codes the `_scheme` in the callback url to
`https` so that airflow generates correct urls when run behind a proxy
that terminates tls. But this means that google auth can't be used when
running without https--for example, during local development. Also,
hard-coding `_scheme` isn't the correct solution to the problem of
running behind a proxy. Instead, the proxy should be configured to set
the `X-Forwarded-Proto` header to `https`; Flask interprets this header
and generates the appropriate callback url without hard-coding the
scheme.
    @jmcarp
    jmcarp committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    862bd59 View commit details
    Browse the repository at this point in the history