Group id is mandatory configurtion option for confluent_kafka 2.4.0+ #39559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
changed the title
The group.id parameter has been optional before 2.4.0 version of confluent_kafka relased on 7th of May. This started to fail our integration tests (cool). This PR adds "group.id" as extra field and sets the defaults for integration testing.
potiuk
force-pushed
the
fix-group-id-required
branch
from
d9e2afe
to
e63e32f
Compare
|
cc: @dylanbstorey -> our integration tests started to fail with latest |
eladkal
approved these changes
May 11, 2024
|
Yeah that should be all. |
pateash
pushed a commit
to pateash/airflow
that referenced
this pull request
May 13, 2024
…pache#39559) The group.id parameter has been optional before 2.4.0 version of confluent_kafka relased on 7th of May. This started to fail our integration tests (cool). This PR adds "group.id" as extra field and sets the defaults for integration testing.
utkarsharma2
added
the
changelog:skip
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
…pache#39559) The group.id parameter has been optional before 2.4.0 version of confluent_kafka relased on 7th of May. This started to fail our integration tests (cool). This PR adds "group.id" as extra field and sets the defaults for integration testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The group.id parameter has been optional before 2.4.0 version of confluent_kafka relased on 7th of May. This started to fail our integration tests (cool).
This PR adds "group.id" as extra field and sets the defaults for integration testing.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.