-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format DAG run count #39684
Format DAG run count #39684
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
then I think we need to add an overlay to show the real value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to comment of @raphaelauv - really like this and I had also challenges in the past with 100k+ DAG runs in our environment.
Can you add a "title" which just renders a pop-up with you run with the mouse over it? Then I think it is OK to approve and merge.
After @jscheffl's suggestions then I think this is good. Ultimately, I don't know if total run state count is all that useful on the homepage. But that's a question for when we rewrite this page. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this in for 2.10
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
* format dag run count * Add full count to tooltip and fix linting --------- Co-authored-by: Brent Bovenzi <[email protected]>
DAGs with many runs are badly formatted inside the circle.
Current:
What I think could be better:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.