Improve code coverage for CgroupTaskRunner #39896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if the CgroupTaskRunner should be deprecated? There's very limited documentation on it, and I think it's pretty unknown and rarely used? |
dirrao
approved these changes
May 29, 2024
potiuk
approved these changes
May 29, 2024
It's a niche case but pretty useful |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
May 29, 2024
This reverts commit 0eb0195.
|
I revert them in #39915 for now - seems that when running on self-hosted runners, they are failing. I also found out that the tests fail on MacOS for development so we will need to improve that. |
potiuk
added a commit
that referenced
this pull request
May 29, 2024
fdemiane
pushed a commit
to fdemiane/airflow
that referenced
this pull request
Jun 6, 2024
fdemiane
pushed a commit
to fdemiane/airflow
that referenced
this pull request
Jun 6, 2024
…pache#39915) This reverts commit 0eb0195.
jannisko
pushed a commit
to jannisko/airflow
that referenced
this pull request
Jun 15, 2024
…pache#39915) This reverts commit 0eb0195.
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
…pache#39915) This reverts commit 0eb0195.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more unit tests for CgroupTaskRunner, improve code coverage from 30% to 75%
related: #35127
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.