Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add git-sync-ssh secret template #39936

Merged
merged 13 commits into from
Jun 19, 2024
Merged

Conversation

romsharon98
Copy link
Contributor

add git-sync-ssh secret as part of the chart in template.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

chart/templates/secrets/git-ssh-key-secret.yaml Outdated Show resolved Hide resolved
chart/values.yaml Outdated Show resolved Hide resolved
chart/templates/secrets/git-ssh-key-secret.yaml Outdated Show resolved Hide resolved
@romsharon98 romsharon98 self-assigned this Jun 5, 2024
chart/values.schema.json Outdated Show resolved Hide resolved
chart/templates/secrets/git-ssh-key-secret.yaml Outdated Show resolved Hide resolved
helm_tests/other/test_git_sync_scheduler.py Outdated Show resolved Hide resolved
helm_tests/other/test_git_sync_scheduler.py Outdated Show resolved Hide resolved
helm_tests/other/test_git_sync_scheduler.py Outdated Show resolved Hide resolved
Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@potiuk
Copy link
Member

potiuk commented Jun 17, 2024

@jedcunningham :) ? Waits for your approval..

chart/values.schema.json Outdated Show resolved Hide resolved
chart/values.yaml Outdated Show resolved Hide resolved
chart/values.yaml Outdated Show resolved Hide resolved
@jedcunningham jedcunningham merged commit f81abd6 into apache:main Jun 19, 2024
66 checks passed
@romsharon98
Copy link
Contributor Author

@jedcunningham , thank you for your detailed work on this PR—it’s greatly appreciated!

@utkarsharma2 utkarsharma2 added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jul 1, 2024
@utkarsharma2 utkarsharma2 added this to the Airflow Helm Chart 1.15.0 milestone Jul 1, 2024
romsharon98 added a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants