Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests to Apache Kafka hooks #40140

Closed
wants to merge 3 commits into from

Conversation

shahar1
Copy link
Contributor

@shahar1 shahar1 commented Jun 8, 2024

related: #35127


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@shahar1 shahar1 force-pushed the add-kafka-base-hook-unit-tests branch from 7b08147 to 99a0de1 Compare June 8, 2024 13:48
@shahar1 shahar1 marked this pull request as draft June 8, 2024 14:59
@shahar1 shahar1 changed the title Add unit tests to Apache Kafka base hook Add unit tests to Apache Kafka hooks Jun 8, 2024
@shahar1 shahar1 force-pushed the add-kafka-base-hook-unit-tests branch from 99a0de1 to 84a2179 Compare June 8, 2024 15:07
@shahar1 shahar1 marked this pull request as ready for review June 8, 2024 15:13
@shahar1 shahar1 force-pushed the add-kafka-base-hook-unit-tests branch from 84a2179 to e7ccea9 Compare June 8, 2024 15:18
@shahar1 shahar1 requested a review from eladkal June 8, 2024 15:21
@shahar1 shahar1 force-pushed the add-kafka-base-hook-unit-tests branch from e7ccea9 to 988f6aa Compare June 8, 2024 16:51
@potiuk
Copy link
Member

potiuk commented Jun 8, 2024

Conflicts.

@shahar1 shahar1 force-pushed the add-kafka-base-hook-unit-tests branch from 988f6aa to e7e0ad9 Compare June 8, 2024 20:54
@shahar1 shahar1 force-pushed the add-kafka-base-hook-unit-tests branch from a7e9c44 to cbbf003 Compare June 8, 2024 21:00
@shahar1
Copy link
Contributor Author

shahar1 commented Jun 8, 2024

Conflicts.

Apologies for the confusion - this PR should have been merged before #40142, as the latter already includes this one's commit.
Basically, there are now 0 files to merge 😅
I guess that it should either be closed or merged for the protocol.

@eladkal
Copy link
Contributor

eladkal commented Jun 9, 2024

Then lets just close

@eladkal eladkal closed this Jun 9, 2024
@shahar1 shahar1 deleted the add-kafka-base-hook-unit-tests branch June 12, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants