-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Code Coverage webserver code and Fix TypeError and AttributeError in Views.py #40254
Adding Code Coverage webserver code and Fix TypeError and AttributeError in Views.py #40254
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
You’ll need to revert the whitespace changes, they cause the linter to fail. |
Will do thanks! |
0a3c7a1
to
dd9bd27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, a few nits and questions
@potiuk a test that seems to be completely unrelated to these changes is failing. Any recommendation here? |
I re-run it (next time you can do it as well -> top-right |
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
…ror in Views.py (apache#40254) * Fix unit tests for coverage issue and refactor request handling * Spaces fix * Adding coverage * Fixed spacing * Changes before repo fix * Increased Coverage to 85%, adding proper mock dag generation and response * Fixing conflicts * Fixing conflicts * Re-added reset_dagruns mistake * Fixed linting issues * linting issues * Added Missing testCases for taskmap.py to 100% * Pre-commit fixes * Pre-commit fixes * Removed unassigned dag_run functionality * Fix unittest date error * Resolving Pre-commit single quotation marks * Resolving hidden conflicts after rebasing * fix pre-commit * fix pre-commit * added test case for invalid XCom TasKInstance --------- Co-authored-by: root <[email protected]> Co-authored-by: Ryan Hatter <[email protected]> Co-authored-by: vboxuser <[email protected]>
Improved code coverage in these following spaces in both Webserver and Core:
Run: Core:
python scripts/cov/core_coverage.py
Run: Webserver:
python scripts/cov/www_coverage.py
airflow/models/taskmap.py
- Increased from 82% to 100% Coverageairflow/www/widgets.py
- Increased from 79% to 100% Coverageairflow/www/views.py
- Help increase Coverage from 78% to 85%Related: #35127
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.