Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update best-practices.rst example phrase. #40505

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Update best-practices.rst example phrase. #40505

merged 1 commit into from
Jul 2, 2024

Conversation

simi
Copy link
Contributor

@simi simi commented Jun 30, 2024

I'm not native speaker, but the original phrasing seemed strange to me.

Copy link

boring-cyborg bot commented Jun 30, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@simi
Copy link
Contributor Author

simi commented Jun 30, 2024

I'll fix CI.

- minor rephrase of example
@simi
Copy link
Contributor Author

simi commented Jun 30, 2024

updated @potiuk

@potiuk potiuk merged commit 5b2becb into apache:main Jul 2, 2024
38 checks passed
Copy link

boring-cyborg bot commented Jul 2, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@simi simi deleted the patch-1 branch July 2, 2024 20:48
@utkarsharma2 utkarsharma2 added the type:doc-only Changelog: Doc Only label Jul 12, 2024
@utkarsharma2 utkarsharma2 added this to the Airflow 2.9.3 milestone Jul 12, 2024
utkarsharma2 pushed a commit that referenced this pull request Jul 12, 2024
- minor rephrase of example

(cherry picked from commit 5b2becb)
utkarsharma2 pushed a commit that referenced this pull request Jul 12, 2024
- minor rephrase of example

(cherry picked from commit 5b2becb)
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
- minor rephrase of example
@ephraimbuddy ephraimbuddy added changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) and removed type:doc-only Changelog: Doc Only labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) kind:documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants