-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notes about passing secrets via environment variables #40519
Add notes about passing secrets via environment variables #40519
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good to me. Just thinking whether we should use warning
🤔
Warnings are when you are doing somethign and you should be careful, I think it's just "common sense" to not pass secrets this way - just stating it explicitly as separate chapter is probably a bit more powerful - like just a "normal" thing :D. Warnings are - in a way - a bit less visible, when you want to find "how do I do something" - separate chapters are likely more discoverable, and I'd usually use them to drag attention to certain un-obvious aspect of something that you want to read about - in this case it's just plainly stating "don't do it". |
sounds good 🙂 |
(cherry picked from commit 07e6eb8)
(cherry picked from commit 07e6eb8)
(cherry picked from commit 07e6eb8)
(cherry picked from commit 07e6eb8)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.