Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP-44 make database isolation mode work in Breeze #40894

Merged
merged 1 commit into from
Jul 20, 2024

Commits on Jul 20, 2024

  1. AIP-44 make database isolation mode work in Breeze

    With this PR, it is possible to get a working "DB isolation" working
    solution with celery executor. From my tests it works comparably
    fast to the non-DB isolation executor.
    
    Things changed here:
    
    * remove "schedule_downstream_tasks" endpoint. It is currently
      not possible to get it as DAG object is removed during
      serialization and this is where this method calculates which
      tasks to schedule
    
    * when we are forcing DB access in DB isolation mode, we print
      log message that we are switching to using DB for appropriate
      components. We also make sure to remove DB configuration just
      in case it is set (this allows to run tests in breeze environment
      with more certainty)
    
    * the detection whether to force direct DB access is made in
      _main - this way regular commands run in breeze (migrate/user
      etc. can use the DB while intializing the environment and actions
      can be logged to DB or via RPC calls.
    
    * improved diagnostics
    
    Co-authored-by: Vincent <[email protected]>
    potiuk and vincbeck committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    07e5b10 View commit details
    Browse the repository at this point in the history