Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RedshiftDataOperator not running in deferred mode when it should #41206

Merged
merged 9 commits into from
Aug 7, 2024
+53 −5
Merged

Fix RedshiftDataOperator not running in deferred mode when it should #41206

Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7c4a5bf
Ensure operator goes into deferrable mode
borismo Aug 2, 2024
adcb848
Merge branch 'main' into main
borismo Aug 2, 2024
68e4069
Merge branch 'apache:main' into main
borismo Aug 3, 2024
360ee8f
Remove commented out code
borismo Aug 3, 2024
73ff6b9
Test when not waiting for completion
borismo Aug 3, 2024
b5f886d
Merge branch 'apache:main' into main
borismo Aug 3, 2024
f78d690
Add entry to changelog
borismo Aug 7, 2024
e62ab3f
Merge remote-tracking branch 'origin/main'
borismo Aug 7, 2024
862163f
Rephrase warning
borismo Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions airflow/providers/amazon/aws/operators/redshift_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,8 @@ def execute(self, context: Context) -> GetStatementResultResponseTypeDef | str:

# Set wait_for_completion to False so that it waits for the status in the deferred task.
wait_for_completion = self.wait_for_completion
if self.deferrable and self.wait_for_completion:
self.wait_for_completion = False
if self.deferrable:
wait_for_completion = False

self.statement_id = self.hook.execute_query(
database=self.database,
Expand All @@ -144,7 +144,7 @@ def execute(self, context: Context) -> GetStatementResultResponseTypeDef | str:
poll_interval=self.poll_interval,
)

if self.deferrable:
if self.deferrable and self.wait_for_completion:
is_finished = self.hook.check_query_is_finished(self.statement_id)
if not is_finished:
self.defer(
Expand Down