Add DatasetDagRunQueue to all the consuming DAGs of a dataset alias #41264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lee-W
force-pushed
the
shift-dataset-aliases-in-dag-schedule-resolution-before-dataset-event-is-created
branch
3 times, most recently
from
c32fc46
to
c70f670
Compare
Lee-W
changed the title
Lee-W
force-pushed
the
shift-dataset-aliases-in-dag-schedule-resolution-before-dataset-event-is-created
branch
2 times, most recently
from
87bf7d3
to
2aa49d9
Compare
Lee-W
requested review from
uranusjr,
potiuk,
kaxil,
XD-DENG and
ashb
as code owners
Lee-W
force-pushed
the
shift-dataset-aliases-in-dag-schedule-resolution-before-dataset-event-is-created
branch
3 times, most recently
from
1a21af9
to
f3375a2
Compare
uranusjr
reviewed
Aug 6, 2024
uranusjr
reviewed
Aug 6, 2024
…e object into queue_dagruns
…ink to a dag that was not previously link to the resolved dataset
…ding to the new feature added
Lee-W
force-pushed
the
shift-dataset-aliases-in-dag-schedule-resolution-before-dataset-event-is-created
branch
from
bc9b269
to
5e27790
Compare
phanikumv
approved these changes
Aug 7, 2024
phanikumv
deleted the
shift-dataset-aliases-in-dag-schedule-resolution-before-dataset-event-is-created
branch
ephraimbuddy
added
changelog:skip
molcay
pushed a commit
to VladaZakharova/airflow
that referenced
this pull request
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Ever since #40693, we have been able to schedule a DAG based on DatasetAlias. When a dataset alias is resolved in a producer DAG for the first time, a consumer DAG that depends on that dataset alias will have to wait for the next round of DAG parsing to realize its dependency on the resolved datasets. Consequently, the consumer DAG will need to wait for the second run of the producer DAG to be triggered.
What
This PR created DDRQ for the consuming dags of dataset alias as well. So after the consumer DAG is updated after DAG parsing, it will have DDRQ which might triggers it.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.