Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return empty data instead of None when OpenLineage on_start method is missing #41268

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

kacpermuda
Copy link
Contributor

When DefaultExtractor is used, so the operator has OpenLineage methods implemented (at least one of: on_start, on_complete) we are logging a WARNING each time there is no on_start method. This happens because we are validating OL metadata returned by extractor, here. This validation makes sense and we should keep it, but imho the default extractor should return empty data when there is no on_start method defined, because it means that the on_complete method will be called.

There is no need to return None ourselves and then log a warning because we found a None 😄

Some logs of current behaviour:

[2024-08-05, 15:04:30 UTC] {listener.py:383} DEBUG - Executing OpenLineage process - on_running - pid 376
[2024-08-05, 15:04:30 UTC] {manager.py:149} DEBUG - extractor for CustomOperator is <class 'airflow.providers.openlineage.extractors.base.DefaultExtractor'>
[2024-08-05, 15:04:30 UTC] {manager.py:98} DEBUG - Using extractor DefaultExtractor task_type=CustomOperator airflow_dag_id=dag task_id=task airflow_run_id=manual__2024-08-05T15:04:29.761674+00:00 
[2024-08-05, 15:04:30 UTC] {base.py:101} DEBUG - Trying to execute `get_openlineage_facets_on_start` for CustomOperator.
[2024-08-05, 15:04:30 UTC] {base.py:112} DEBUG - Operator CustomOperator does not have the get_openlineage_facets_on_start method.
[2024-08-05, 15:04:30 UTC] {manager.py:104} DEBUG - Found task metadata for operation task: None
[2024-08-05, 15:04:30 UTC] {manager.py:267} WARNING - Extractor returns non-valid metadata: None

After the change, we would get rid of this warning. We would still get the information that there is no on_start method and metadata found would be OperatorLineage()


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@mobuchowski mobuchowski merged commit a7353d2 into apache:main Aug 5, 2024
53 checks passed
@kacpermuda kacpermuda deleted the ol-fix-warning-log branch August 6, 2024 07:28
molcay pushed a commit to VladaZakharova/airflow that referenced this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants