fix: return empty data instead of None when OpenLineage on_start method is missing #41268
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When DefaultExtractor is used, so the operator has OpenLineage methods implemented (at least one of: on_start, on_complete) we are logging a WARNING each time there is no on_start method. This happens because we are validating OL metadata returned by extractor, here. This validation makes sense and we should keep it, but imho the default extractor should return empty data when there is no on_start method defined, because it means that the on_complete method will be called.
There is no need to return None ourselves and then log a warning because we found a None 😄
Some logs of current behaviour:
After the change, we would get rid of this warning. We would still get the information that there is no on_start method and metadata found would be
OperatorLineage()
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.