Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DataflowStartYamlJobOperator #41576

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

moiseenkov
Copy link
Contributor

Add DataflowStartYamlJobOperator as a replacement option for DataflowStartSqlJobOperator.

@moiseenkov moiseenkov force-pushed the add-dataflow-beam-yaml-operator branch 2 times, most recently from e5af5c4 to 41ffb5d Compare August 21, 2024 08:14
Copy link
Contributor

@shahar1 shahar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall!
I got a small comment regarding reusability.

airflow/providers/google/cloud/hooks/dataflow.py Outdated Show resolved Hide resolved
airflow/providers/google/cloud/operators/dataflow.py Outdated Show resolved Hide resolved
@moiseenkov
Copy link
Contributor Author

Looks good overall!
I got a small comment regarding reusability.

@shahar1 ,
Thanks for the review. Please take a look at the fixes.

@moiseenkov moiseenkov force-pushed the add-dataflow-beam-yaml-operator branch from bfa18bf to 3062beb Compare September 2, 2024 12:24
@moiseenkov moiseenkov force-pushed the add-dataflow-beam-yaml-operator branch from 3062beb to 5a4a34d Compare September 2, 2024 12:41
@potiuk potiuk merged commit 7d3a402 into apache:main Sep 2, 2024
56 checks passed
Illumaria pushed a commit to Illumaria/airflow that referenced this pull request Sep 3, 2024
* Add DataflowStartYamlJobOperator

* Refactor hook and operator

---------

Co-authored-by: Eugene Galan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants