fix: only treat null/undefined as falsy when rendering XComEntry (#42… #42213
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…che#42199) fix: only treat null, undefined or NaN as NULL in XComEntry render fix: use coalescing nullish check + isNaN fix: only treat null/undefined as falsy when rendering XComEntry (cherry picked from commit ade9de1)
pierrejeambrun
requested review from
ryanahamilton,
ashb and
bbovenzi
as code owners
boring-cyborg
bot
added
area:UI
pierrejeambrun
added
type:bug-fix
jscheffl
approved these changes
Sep 13, 2024
ephraimbuddy
pushed a commit
that referenced
this pull request
Sep 13, 2024
) (#42213) fix: only treat null, undefined or NaN as NULL in XComEntry render fix: use coalescing nullish check + isNaN fix: only treat null/undefined as falsy when rendering XComEntry (cherry picked from commit ade9de1) Co-authored-by: Detlev V. <[email protected]>
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit ade9de1)