Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-3462] Move TaskReschedule out of models.py #4618

Merged
merged 1 commit into from
Jan 30, 2019
Merged

[AIRFLOW-3462] Move TaskReschedule out of models.py #4618

merged 1 commit into from
Jan 30, 2019

Conversation

seelmann
Copy link
Member

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR:
    • Class TaskReschedule is moved out of model.py/models/__init__.py
    • Some tweaks to avoid and eliminate circular dependencies (move ID_LEN to base, use strings instead of object references in foreign key constraint)

Tests

  • My PR does not need testing for this extremely good reason:
    • Refactoring only

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

Code Quality

  • Passes flake8

@feng-tao
Copy link
Member

@seelmann , flake8 fails

@ashb
Copy link
Member

ashb commented Jan 30, 2019

Rebase to latest master to fix flake8

@codecov-io
Copy link

Codecov Report

Merging #4618 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4618      +/-   ##
==========================================
+ Coverage   74.26%   74.26%   +<.01%     
==========================================
  Files         423      424       +1     
  Lines       27788    27795       +7     
==========================================
+ Hits        20637    20643       +6     
- Misses       7151     7152       +1
Impacted Files Coverage Δ
airflow/models/connection.py 64.24% <100%> (+0.21%) ⬆️
airflow/models/slamiss.py 93.33% <100%> (ø) ⬆️
airflow/jobs.py 77.38% <100%> (ø) ⬆️
airflow/models/taskreschedule.py 100% <100%> (ø)
airflow/models/__init__.py 92.44% <100%> (-0.14%) ⬇️
airflow/sensors/base_sensor_operator.py 97.91% <100%> (+0.04%) ⬆️
airflow/models/base.py 87.5% <100%> (+1.78%) ⬆️
airflow/ti_deps/deps/ready_to_reschedule.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ebecd6...e773ad8. Read the comment docs.

@feng-tao
Copy link
Member

LGTM

@feng-tao feng-tao merged commit 8e6bca1 into apache:master Jan 30, 2019
ashb pushed a commit to ashb/airflow that referenced this pull request Mar 27, 2019
wmorris75 pushed a commit to modmed/incubator-airflow that referenced this pull request Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants