Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-XXX] Add missing class references #4644

Merged
merged 1 commit into from
Feb 5, 2019

Conversation

mik-laj
Copy link
Member

@mik-laj mik-laj commented Feb 3, 2019

Make sure you have checked all steps below.

Jira

No applicable

Description

List of classes generated by my script.
Now the list is definitely full and nothing is missing from it. Now you have to watch to keep it fresh.

Tests

No applicable.

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

No applicable.

Code Quality

No applicable.

@codecov-io
Copy link

Codecov Report

Merging #4644 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4644      +/-   ##
=========================================
- Coverage    74.3%   74.3%   -0.01%     
=========================================
  Files         427     427              
  Lines       27873   27873              
=========================================
- Hits        20712   20711       -1     
- Misses       7161    7162       +1
Impacted Files Coverage Δ
airflow/contrib/operators/databricks_operator.py 90.51% <ø> (ø) ⬆️
airflow/contrib/operators/sftp_to_s3_operator.py 100% <ø> (ø) ⬆️
airflow/contrib/operators/s3_to_sftp_operator.py 100% <ø> (ø) ⬆️
airflow/models/__init__.py 92.98% <0%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f02e45...f7db6c9. Read the comment docs.

@mik-laj
Copy link
Member Author

mik-laj commented Feb 5, 2019

@ashb Can you look at it? It repairs the old version of the documentation. I want to start from this commita to make further changes.

@ashb ashb merged commit 40c14e5 into apache:master Feb 5, 2019
wmorris75 pushed a commit to modmed/incubator-airflow that referenced this pull request Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants