-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-3857] spark_submit_hook cannot kill driver pod in kubernetes #4678
Conversation
54db3c2
to
0f6f444
Compare
Codecov Report
@@ Coverage Diff @@
## master #4678 +/- ##
==========================================
+ Coverage 74.34% 74.36% +0.01%
==========================================
Files 429 429
Lines 27950 27951 +1
==========================================
+ Hits 20779 20785 +6
+ Misses 7171 7166 -5
Continue to review full report at Codecov.
|
0f6f444
to
1a90300
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @ogirardot
C02VF05JHV2T:incubator-airflow fdriesprong$ python3
Python 3.7.2 (default, Dec 27 2018, 07:35:06)
[Clang 10.0.0 (clang-1000.11.45.5)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import kubernetes
>>> kubernetes.client.V1DeleteOptions()
{'api_version': None,
'dry_run': None,
'grace_period_seconds': None,
'kind': None,
'orphan_dependents': None,
'preconditions': None,
'propagation_policy': None}
>>> from airflow.contrib.kubernetes import kube_client
>>> kube_client.V1DeleteOptions()
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
AttributeError: module 'airflow.contrib.kubernetes.kube_client' has no attribute 'V1DeleteOptions'
…apache#4678) (cherry picked from commit 3389fe2)
…apache#4678) (cherry picked from commit 3389fe2)
Jira
Description
Tests
Commits
Documentation
Code Quality
flake8