-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-3885] ~2.5x speed-up for backfill tests #4731
Merged
feng-tao
merged 1 commit into
apache:master
from
lyft:astahlman/airflow-3885-speedup-backfill-tests
Feb 19, 2019
Merged
[AIRFLOW-3885] ~2.5x speed-up for backfill tests #4731
feng-tao
merged 1 commit into
apache:master
from
lyft:astahlman/airflow-3885-speedup-backfill-tests
Feb 19, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The BackfillJobTest suite now takes 57 seconds vs. the baseline of 147 seconds on my laptop. A couple of optimizations: - Don't sleep() if we are running unit tests - Don't backfill more DagRuns than needed (reduced from 5 to 2, since we only need 2 DagRuns to verify that we can run backwards) I've also made a few tests reentrant by clearing out the Pool, DagRun, and TaskInstance table between runs.
Codecov Report
@@ Coverage Diff @@
## master #4731 +/- ##
==========================================
+ Coverage 74.65% 74.66% +<.01%
==========================================
Files 430 430
Lines 27991 27994 +3
==========================================
+ Hits 20897 20901 +4
+ Misses 7094 7093 -1
Continue to review full report at Codecov.
|
astahlman
changed the title
[WIP] [AIRFLOW-3885] ~2.5x speed-up for backfill tests
[AIRFLOW-3885] ~2.5x speed-up for backfill tests
Feb 19, 2019
cc @feng-tao |
feng-tao
approved these changes
Feb 19, 2019
antonimaciej
pushed a commit
to PolideaInternal/airflow
that referenced
this pull request
Feb 26, 2019
The BackfillJobTest suite now takes 57 seconds vs. the baseline of 147 seconds on my laptop. A couple of optimizations: - Don't sleep() if we are running unit tests - Don't backfill more DagRuns than needed (reduced from 5 to 2, since we only need 2 DagRuns to verify that we can run backwards) I've also made a few tests reentrant by clearing out the Pool, DagRun, and TaskInstance table between runs.
ashb
pushed a commit
to ashb/airflow
that referenced
this pull request
Mar 6, 2019
The BackfillJobTest suite now takes 57 seconds vs. the baseline of 147 seconds on my laptop. A couple of optimizations: - Don't sleep() if we are running unit tests - Don't backfill more DagRuns than needed (reduced from 5 to 2, since we only need 2 DagRuns to verify that we can run backwards) I've also made a few tests reentrant by clearing out the Pool, DagRun, and TaskInstance table between runs.
wmorris75
pushed a commit
to modmed/incubator-airflow
that referenced
this pull request
Jul 29, 2019
The BackfillJobTest suite now takes 57 seconds vs. the baseline of 147 seconds on my laptop. A couple of optimizations: - Don't sleep() if we are running unit tests - Don't backfill more DagRuns than needed (reduced from 5 to 2, since we only need 2 DagRuns to verify that we can run backwards) I've also made a few tests reentrant by clearing out the Pool, DagRun, and TaskInstance table between runs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
Description
The BackfillJobTest suite now takes 57 seconds vs. the baseline of 147
seconds on my laptop.
A couple of optimizations:
only need 2 DagRuns to verify that we can run backwards)
I've also made a few tests reentrant by clearing out the Pool, DagRun,
and TaskInstance table between runs.
Tests
Commits
Documentation
Code Quality
flake8