Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-3987] Unify GCP's Connection IDs #4818

Merged
merged 6 commits into from
Mar 25, 2019

Conversation

ryanyuan
Copy link
Contributor

@ryanyuan ryanyuan commented Mar 2, 2019

Unify GCP's Connection IDs

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow-3987 issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

Code Quality

  • Passes flake8

@codecov-io
Copy link

codecov-io commented Mar 2, 2019

Codecov Report

Merging #4818 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4818      +/-   ##
==========================================
- Coverage   75.74%   75.74%   -0.01%     
==========================================
  Files         458      458              
  Lines       29850    29849       -1     
==========================================
- Hits        22609    22608       -1     
  Misses       7241     7241
Impacted Files Coverage Δ
airflow/contrib/sensors/bigquery_sensor.py 0% <ø> (ø) ⬆️
...rflow/contrib/operators/bigquery_check_operator.py 0% <ø> (ø) ⬆️
airflow/contrib/operators/gcs_to_bq.py 0% <ø> (ø) ⬆️
airflow/contrib/hooks/bigquery_hook.py 60.89% <ø> (ø) ⬆️
airflow/contrib/operators/bigquery_get_data.py 0% <ø> (ø) ⬆️
airflow/contrib/operators/bigquery_operator.py 93.57% <ø> (ø) ⬆️
airflow/contrib/operators/bigquery_to_bigquery.py 0% <ø> (ø) ⬆️
...ontrib/operators/bigquery_table_delete_operator.py 0% <ø> (ø) ⬆️
airflow/contrib/operators/gcs_to_s3.py 96.77% <ø> (ø) ⬆️
airflow/utils/db.py 90.19% <ø> (-0.1%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb32b77...f1330ed. Read the comment docs.

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb!

Unify GCP's Connection IDs; Merge with master
@ryanyuan
Copy link
Contributor Author

ryanyuan commented Mar 9, 2019

PTAL @kaxil

@kaxil
Copy link
Member

kaxil commented Mar 13, 2019

I'll have a look at this tonight or at most by the end of this week :)

@Fokko
Copy link
Contributor

Fokko commented Mar 23, 2019

@ryanyuan Could you resolve the conflicts? :-)

UPDATING.md Outdated Show resolved Hide resolved
UPDATING.md Outdated
variant. Values like ``google_cloud_storage_default``, ``bigquery_default``,
``google_cloud_datastore_default`` have been abandoned. The configuration of
connections in the database have been preserved, but in every place where they
were used, they should be indicated explicitly.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rephrase the last line ?

Copy link
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits. LGTM

@ryanyuan
Copy link
Contributor Author

@potiuk @kaxil Thanks for the review.

Copy link
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @ryanyuan

@kaxil kaxil merged commit e92f09b into apache:master Mar 25, 2019
cthenderson pushed a commit to cthenderson/apache-airflow that referenced this pull request Apr 16, 2019
andriisoldatenko pushed a commit to andriisoldatenko/airflow that referenced this pull request Jul 26, 2019
wmorris75 pushed a commit to modmed/incubator-airflow that referenced this pull request Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants