-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-4020] Remove viewer DAG edit permissions #4845
Conversation
tests/www/test_views.py
Outdated
self.login(username='test_viewer', | ||
password='test_viewer') | ||
resp = self.client.get(url, follow_redirects=True) | ||
self.check_content_not_in_response('example_bash_operator', resp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is Viewer not allowed to see this view? It's a read-only view.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, wrong unit test. I changed to use /refresh endpoint instead.
9e8f91c
to
ccfd3af
Compare
PTAL @ashb |
Codecov Report
@@ Coverage Diff @@
## master #4845 +/- ##
==========================================
- Coverage 74.73% 74.73% -0.01%
==========================================
Files 449 449
Lines 28959 28961 +2
==========================================
+ Hits 21642 21643 +1
- Misses 7317 7318 +1
Continue to review full report at Codecov.
|
(cherry picked from commit dda309e)
(cherry picked from commit dda309e)
(cherry picked from commit dda309e)
Make sure you have checked all steps below.
Jira
Description
Viewer shouldn't be able to have write/edit access on DAG View-menu
Tests
Commits
Documentation
Code Quality
flake8