Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-4052] Allow filtering using "event" and "owner" in "Log" view #4881

Merged
merged 1 commit into from
Mar 8, 2019

Conversation

XD-DENG
Copy link
Member

@XD-DENG XD-DENG commented Mar 8, 2019

Jira

Description

In the RBAC UI, users can check Logs ("Browse" -> "Logs"). But they could only use "dag_id", "task_id", "execution_date", or "extra" to filter.

Before This Change:
screen shot 2019-03-08 at 5 50 58 pm

However, filtering using "event" and "owner" will be very useful (to allow users to check specific events that happened, or check what a specific user did).

In this PR, "event" and "owner" are added into search_columns.

After This Change:
screen shot 2019-03-08 at 10 00 26 pm

In the RBAC UI, users can check Logs. But they could only use "dag_id", "task_id", "execution_date", or "extra" to filter, while filtering using "event" and "owner" will be very useful (to allow users to check specific events that happened, or check what a specific user did).
@feng-tao
Copy link
Member

feng-tao commented Mar 8, 2019

👍LGTM, @XD-DENG are you able to merge the pr on your side?

@XD-DENG
Copy link
Member Author

XD-DENG commented Mar 8, 2019

@feng-tao not yet. Please help merge. Thanks!

@feng-tao feng-tao merged commit 5ef8e3f into apache:master Mar 8, 2019
@XD-DENG XD-DENG deleted the patch-5 branch March 9, 2019 22:34
andriisoldatenko pushed a commit to andriisoldatenko/airflow that referenced this pull request Jul 26, 2019
apache#4881)

In the RBAC UI, users can check Logs. But they could only use "dag_id", "task_id", "execution_date", or "extra" to filter, while filtering using "event" and "owner" will be very useful (to allow users to check specific events that happened, or check what a specific user did).
wmorris75 pushed a commit to modmed/incubator-airflow that referenced this pull request Jul 29, 2019
apache#4881)

In the RBAC UI, users can check Logs. But they could only use "dag_id", "task_id", "execution_date", or "extra" to filter, while filtering using "event" and "owner" will be very useful (to allow users to check specific events that happened, or check what a specific user did).
@XD-DENG
Copy link
Member Author

XD-DENG commented May 14, 2020

Hi @ashb and @kaxil , mind helping cherry-pick this commit into v-10? It was labelled to be released in 1.10.3, however until today it's still only in master branch. It's a very simple change but may be useful.

@kaxil kaxil added this to the Airflow 1.10.11 milestone May 14, 2020
@kaxil
Copy link
Member

kaxil commented May 14, 2020

Thanks for the note @XD-DENG - I have added it to 1.10.11 milestone and cherry-picked it too :)

kaxil pushed a commit that referenced this pull request May 14, 2020
#4881)

In the RBAC UI, users can check Logs. But they could only use "dag_id", "task_id", "execution_date", or "extra" to filter, while filtering using "event" and "owner" will be very useful (to allow users to check specific events that happened, or check what a specific user did).
@XD-DENG
Copy link
Member Author

XD-DENG commented May 14, 2020

Thanks @kaxil !

kaxil pushed a commit that referenced this pull request Jul 1, 2020
#4881)

In the RBAC UI, users can check Logs. But they could only use "dag_id", "task_id", "execution_date", or "extra" to filter, while filtering using "event" and "owner" will be very useful (to allow users to check specific events that happened, or check what a specific user did).
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
In the RBAC UI, users can check Logs. But they could only use "dag_id", "task_id", "execution_date", or "extra" to filter, while filtering using "event" and "owner" will be very useful (to allow users to check specific events that happened, or check what a specific user did).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants