-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-4052] Allow filtering using "event" and "owner" in "Log" view #4881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the RBAC UI, users can check Logs. But they could only use "dag_id", "task_id", "execution_date", or "extra" to filter, while filtering using "event" and "owner" will be very useful (to allow users to check specific events that happened, or check what a specific user did).
ffinfo
approved these changes
Mar 8, 2019
👍LGTM, @XD-DENG are you able to merge the pr on your side? |
@feng-tao not yet. Please help merge. Thanks! |
andriisoldatenko
pushed a commit
to andriisoldatenko/airflow
that referenced
this pull request
Jul 26, 2019
apache#4881) In the RBAC UI, users can check Logs. But they could only use "dag_id", "task_id", "execution_date", or "extra" to filter, while filtering using "event" and "owner" will be very useful (to allow users to check specific events that happened, or check what a specific user did).
wmorris75
pushed a commit
to modmed/incubator-airflow
that referenced
this pull request
Jul 29, 2019
apache#4881) In the RBAC UI, users can check Logs. But they could only use "dag_id", "task_id", "execution_date", or "extra" to filter, while filtering using "event" and "owner" will be very useful (to allow users to check specific events that happened, or check what a specific user did).
Thanks for the note @XD-DENG - I have added it to 1.10.11 milestone and cherry-picked it too :) |
kaxil
pushed a commit
that referenced
this pull request
May 14, 2020
#4881) In the RBAC UI, users can check Logs. But they could only use "dag_id", "task_id", "execution_date", or "extra" to filter, while filtering using "event" and "owner" will be very useful (to allow users to check specific events that happened, or check what a specific user did).
Thanks @kaxil ! |
kaxil
pushed a commit
that referenced
this pull request
Jul 1, 2020
#4881) In the RBAC UI, users can check Logs. But they could only use "dag_id", "task_id", "execution_date", or "extra" to filter, while filtering using "event" and "owner" will be very useful (to allow users to check specific events that happened, or check what a specific user did).
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
In the RBAC UI, users can check Logs. But they could only use "dag_id", "task_id", "execution_date", or "extra" to filter, while filtering using "event" and "owner" will be very useful (to allow users to check specific events that happened, or check what a specific user did).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
Description
In the RBAC UI, users can check Logs ("Browse" -> "Logs"). But they could only use "dag_id", "task_id", "execution_date", or "extra" to filter.
Before This Change:
However, filtering using "event" and "owner" will be very useful (to allow users to check specific events that happened, or check what a specific user did).
In this PR, "event" and "owner" are added into
search_columns
.After This Change: