-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-4472] Use json.dumps/loads for templating lineage data #5253
Conversation
c7a37bb
to
f894a1d
Compare
cc: @feng-tao This is a pre-requisite for the Papermill operator. |
jinja2 cannot use dict/lists as templates hence converting it to json solves this while keeping complexity down.
f894a1d
to
4cd5fa5
Compare
…he#5253) jinja2 cannot use dict/lists as templates hence converting it to json solves this while keeping complexity down.
…he#5253) jinja2 cannot use dict/lists as templates hence converting it to json solves this while keeping complexity down.
…he#5253) jinja2 cannot use dict/lists as templates hence converting it to json solves this while keeping complexity down.
Hi! |
Can you guys release this please? |
Would like to see this one released too. |
I believe it was never meant to be released @kaxil @ashb @bolkedebruin? I am not 100% sure as it has no tests, but I think this one gets rather deeply into the operator/context behaviour and it might have some undesireable effects (on the other hand maybe it's better to cherry-pick it now because otherwise people might hit similar problems when migrating to 2.0)? |
It's meant to be updated significantly. It's about 70% there and I need some time to finish it. |
jinja2 cannot use dict/lists as templates hence converting it to json solves this while keeping complexity down. (cherry picked from commit a6daeb5)
jinja2 cannot use dict/lists as templates hence converting it to json solves this while keeping complexity down. (cherry picked from commit a6daeb5)
jinja2 cannot use dict/lists as templates hence converting it to json solves this while keeping complexity down. (cherry picked from commit a6daeb5)
jinja2 cannot use dict/lists as templates hence converting it to json solves this while keeping complexity down. (cherry picked from commit a6daeb5)
jinja2 cannot use dict/lists as templates hence converting it to json solves this while keeping complexity down. (cherry picked from commit a6daeb5)
jinja2 cannot use dict/lists as templates hence converting it to json solves this while keeping complexity down. (cherry picked from commit a6daeb5)
Make sure you have checked all steps below.
Jira
Description
jinja2 cannot use dict/lists as templates hence converting
it to json solves this while keeping complexity down.
Tests
Is covered.
Commits
Documentation
Code Quality
flake8