-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-4482] Add execution_date to trigger DAG run API response #5260
[AIRFLOW-4482] Add execution_date to trigger DAG run API response #5260
Conversation
Thanks @shuva10v A useful feature to me. I have restarted the failing test which may be due to transient error. |
Codecov Report
@@ Coverage Diff @@
## master #5260 +/- ##
==========================================
+ Coverage 78.39% 78.66% +0.26%
==========================================
Files 470 470
Lines 30013 30013
==========================================
+ Hits 23528 23609 +81
+ Misses 6485 6404 -81
Continue to review full report at Codecov.
|
…pache#5260) (cherry picked from commit 66b3054)
Make sure you have checked all steps below.
Jira
Description
We are using experimental REST API for automating Airflow from Jenkins and our workflow looks like this:
{"message":"Created <DagRun dag_id @ 2019-05-08 11:42:43+00:00: run_id, externally triggered: True>"}
Here is the code - how it works.
Actually it is not a good idea to parse message string for execution_date. So it is proposed to add execution_date in DAG run trigger API response as a field. It makes it possible to get execution_date directly from the response without dirty and unpredictable parsing. After this improvement API response will be like this:
{'execution_date': '2019-05-08T07:03:09+00:00', 'message': 'Created <DagRun dag_id @ 2019-05-08 07:03:09+00:00: manual__2019-05-08T07:03:09+00:00, externally triggered: True>'}
Tests
Asserts added for test_endpoints.test_trigger_dag
Commits
Documentation
Code Quality
flake8