-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-4560] Fix Tez queue parameter name in mapred_queue #5315
[AIRFLOW-4560] Fix Tez queue parameter name in mapred_queue #5315
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5315 +/- ##
==========================================
- Coverage 78.92% 78.91% -0.01%
==========================================
Files 479 479
Lines 30098 30098
==========================================
- Hits 23755 23753 -2
- Misses 6343 6345 +2
Continue to review full report at Codecov.
|
@KevinYang21 Can you please PTAL and help merge this? |
@aliceabe Thank you for the fix, is this something that we can cover by a unit test? |
@KevinYang21 None of the other queue parameters are currently under unit tests, so it seems out of scope for this diff. |
@aliceabe indeed we don't have unit tests on other parameters but it's hard to justify code change w/o unit test only saying it didn't have test. On the other hand, for this particular change I think it is a small enough change with document supporting it that we can merge it now--having tests around it is still preferable, someone else might commit the same typo again and not aware of they're breaking something. |
I see, makes sense @KevinYang21 . Thank you! |
(cherry picked from commit 03ee1c3)
) (cherry picked from commit 03ee1c3)
(cherry picked from commit 03ee1c3)
Jira
Description
The Tez configuration parameter passed is incorrect, it should be
tez.queue.name
and nottez.job.queue.name
.See Tez documentation https://tez.apache.org/releases/0.9.2/tez-api-javadocs/configs/TezConfiguration.html
Tests
Only fixing a typo
Commits
Documentation
Code Quality
flake8
@krishnabhupatiraju @KevinYang21 @bolkedebruin @wolfier