Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-4013] Fix Mark Success/Failed picking all execution_date bug #5616

Merged
merged 1 commit into from
Aug 20, 2019
Merged

[AIRFLOW-4013] Fix Mark Success/Failed picking all execution_date bug #5616

merged 1 commit into from
Aug 20, 2019

Conversation

yuqian90
Copy link
Contributor

@yuqian90 yuqian90 commented Jul 20, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-4013
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    • The bug happens when schedule_interval is None. Marking one task for one day ends up marking all dates as Success or Failed.
    • The fix is by looking up existing DagRun if schedule_interval is None, and only mark the ones falling between start_date and end_date as Success or Failed.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    • Updated test_mark_tasks.py to test the cases where schedule_interval is None.

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@yuqian90
Copy link
Contributor Author

Tagging some authors who worked on those code previously:
@potiuk @bolkedebruin would you be interested in reviewing this change? The bug being fixed here is quite an annoying one. It prevents users from Marking Success/Failed at all as long as schedule_interval is None.

@yuqian90
Copy link
Contributor Author

@potiuk @bolkedebruin would you like to review this?

@de-code
Copy link

de-code commented Aug 9, 2019

This seems to work. I can finally marking individual tasks as failed.

@kaxil kaxil merged commit 46885cc into apache:master Aug 20, 2019
@kaxil
Copy link
Member

kaxil commented Aug 20, 2019

Thanks @yuqian90

ashb pushed a commit that referenced this pull request Aug 22, 2019
Jerryguo pushed a commit to Jerryguo/airflow that referenced this pull request Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants