Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AIRFLOW-5089] Spanner compatibility bug causes missing imports #5703

Merged
merged 1 commit into from
Aug 1, 2019
Merged

[AIRFLOW-5089] Spanner compatibility bug causes missing imports #5703

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ def write_version(filename: str = os.path.join(*["airflow", "git_version"])):
'google-cloud-container>=0.1.1',
'google-cloud-dlp>=0.11.0',
'google-cloud-language>=1.1.1',
'google-cloud-spanner>=1.7.1',
'google-cloud-spanner>=1.7.1, <1.10.0',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is I think that clous-spanner 1.10.0 now needs https://pypi.org/project/google-cloud-iam/#history 0.2.0 but didn't list that as a dep.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. Let's fix it for now to unblock master merges and we will have a separate work on aligning all gcp dependencies.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was slightly wrong, but its related to this:

google-cloud-container 0.3.0 has requirement grpc-google-iam-v1<0.13dev,>=0.12.3, but you'll have grpc-google-iam-v1 0.11.4 which is incompatible.
google-cloud-spanner 1.10.0 has requirement grpc-google-iam-v1<0.13dev,>=0.12.3, but you'll have grpc-google-iam-v1 0.11.4 which is incompatible.

'google-cloud-storage~=1.16',
'google-cloud-translate>=1.3.3',
'google-cloud-videointelligence>=1.7.0',
Expand Down