Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5092] Local CI pull and build also pulls python image #5705

Merged

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Aug 1, 2019

Needed as the pulled image will usually be rebuilt using the
latest python version.

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

Needed as the pulled image will usually be rebuilt using the
latest python version.
@potiuk potiuk requested review from mik-laj and ashb August 1, 2019 11:05
Copy link
Member

@ashb ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though I'm getting a little bit lost in the CI scripts.

@potiuk
Copy link
Member Author

potiuk commented Aug 1, 2019

They are indeed a bit complex :(. Hiding complexity for the users :(. I think it is still better than the previous scripts :D

@potiuk potiuk merged commit 1031cc8 into apache:master Aug 1, 2019
potiuk added a commit that referenced this pull request Aug 1, 2019
Needed as the pulled image will usually be rebuilt using the
latest python version.
dharamsk pushed a commit to postmates/airflow that referenced this pull request Aug 8, 2019
…e#5705)

Needed as the pulled image will usually be rebuilt using the
latest python version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants