-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-4462] Use datetime2 column types when using MSSQL backend #5707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: mattinbits <[email protected]> Co-authored-by: sirVir <[email protected]>
6 tasks
Thanks @mortenbpost I'm off next week so won't be able to look at this until 12th August. |
pylint has poor support for alembic so alembic.op module will fail ci if not ignored.
Change missing columns to datetime2. All columns of datetime are now changed to datetime2. Fix code formatting.
Fix flake8 errors
Hi @ashb, did you have a chance to look at this PR? Pylint is passing now. |
I am not familiar with MSSQL so I'm trusting that this new migration works :) |
ashb
pushed a commit
to ashb/airflow
that referenced
this pull request
Aug 29, 2019
…pache#5707) Change missing columns to datetime2. All columns of datetime are now changed to datetime2. Co-authored-by: mattinbits <[email protected]> Co-authored-by: sirVir <[email protected]> pylint has poor support for alembic so alembic.op module will fail ci if not ignored. Fix code formatting. (cherry picked from commit 93ca8b8)
kaxil
pushed a commit
that referenced
this pull request
Aug 30, 2019
…5707) Change missing columns to datetime2. All columns of datetime are now changed to datetime2. Co-authored-by: mattinbits <[email protected]> Co-authored-by: sirVir <[email protected]> pylint has poor support for alembic so alembic.op module will fail ci if not ignored. Fix code formatting. (cherry picked from commit 93ca8b8)
Jerryguo
pushed a commit
to Jerryguo/airflow
that referenced
this pull request
Sep 2, 2019
…pache#5707) Change missing columns to datetime2. All columns of datetime are now changed to datetime2. Co-authored-by: mattinbits <[email protected]> Co-authored-by: sirVir <[email protected]> pylint has poor support for alembic so alembic.op module will fail ci if not ignored. Fix code formatting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: mattinbits [email protected]
Co-authored-by: sirVir [email protected]
Make sure you have checked all steps below.
Jira
Description
This change address the fact that we need to use datetime2 when using MSSQL server as a backend. pyodbc uses microseconds which datetime doesn't support. One of the sideeffects of this is that trigger dag does not work. Details in JIRA.
Tests
Please note that pylint fails for this since it has poor support for alembic. One way to solve this is to ignore the alembic.op module in pylintrc.
Commits
Documentation
Code Quality
flake8