Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-4462] Use datetime2 column types when using MSSQL backend #5707

Merged
merged 4 commits into from
Aug 23, 2019

Conversation

mortenbpost
Copy link
Contributor

Co-authored-by: mattinbits [email protected]
Co-authored-by: sirVir [email protected]

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-4462
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

This change address the fact that we need to use datetime2 when using MSSQL server as a backend. pyodbc uses microseconds which datetime doesn't support. One of the sideeffects of this is that trigger dag does not work. Details in JIRA.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Please note that pylint fails for this since it has poor support for alembic. One way to solve this is to ignore the alembic.op module in pylintrc.

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@ashb
Copy link
Member

ashb commented Aug 1, 2019

Thanks @mortenbpost I'm off next week so won't be able to look at this until 12th August.

pylint has poor support for alembic so alembic.op module will
fail ci if not ignored.
Change missing columns to datetime2. All columns of datetime are
now changed to datetime2. Fix code formatting.
@sirVir
Copy link
Contributor

sirVir commented Aug 19, 2019

Hi @ashb, did you have a chance to look at this PR? Pylint is passing now.

@ashb
Copy link
Member

ashb commented Aug 23, 2019

I am not familiar with MSSQL so I'm trusting that this new migration works :)

@ashb ashb merged commit 93ca8b8 into apache:master Aug 23, 2019
ashb pushed a commit to ashb/airflow that referenced this pull request Aug 29, 2019
…pache#5707)

Change missing columns to datetime2. All columns of datetime are
now changed to datetime2.

Co-authored-by: mattinbits <[email protected]>
Co-authored-by: sirVir <[email protected]>

pylint has poor support for alembic so alembic.op module will
fail ci if not ignored.

Fix code formatting.

(cherry picked from commit 93ca8b8)
kaxil pushed a commit that referenced this pull request Aug 30, 2019
…5707)

Change missing columns to datetime2. All columns of datetime are
now changed to datetime2.

Co-authored-by: mattinbits <[email protected]>
Co-authored-by: sirVir <[email protected]>

pylint has poor support for alembic so alembic.op module will
fail ci if not ignored.

Fix code formatting.

(cherry picked from commit 93ca8b8)
Jerryguo pushed a commit to Jerryguo/airflow that referenced this pull request Sep 2, 2019
…pache#5707)

Change missing columns to datetime2. All columns of datetime are
now changed to datetime2. 

Co-authored-by: mattinbits <[email protected]>
Co-authored-by: sirVir <[email protected]>

pylint has poor support for alembic so alembic.op module will
fail ci if not ignored.

Fix code formatting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants