Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5130] Use GOOGLE_APPLICATION_CREDENTIALS constant from library #5744

Merged
merged 1 commit into from
Aug 7, 2019

Conversation

mik-laj
Copy link
Member

@mik-laj mik-laj commented Aug 7, 2019

Constant GOOGLE_APPLICATION_CREDENTIALS is used in many places in inconsistent way. I try to organize this small piece of code.

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-XXX
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@mik-laj mik-laj added the provider:google Google (including GCP) related issues label Aug 7, 2019
@mik-laj mik-laj requested a review from potiuk August 7, 2019 06:04
@codecov-io
Copy link

Codecov Report

Merging #5744 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5744      +/-   ##
==========================================
+ Coverage   79.95%   79.97%   +0.01%     
==========================================
  Files         497      498       +1     
  Lines       32078    32151      +73     
==========================================
+ Hits        25649    25713      +64     
- Misses       6429     6438       +9
Impacted Files Coverage Δ
...irflow/contrib/operators/gcp_container_operator.py 95.83% <100%> (ø) ⬆️
airflow/contrib/hooks/gcp_api_base_hook.py 85.47% <100%> (ø) ⬆️
...ow/contrib/operators/bigquery_to_mysql_operator.py 72.91% <0%> (ø)
airflow/utils/dag_processing.py 58.98% <0%> (+0.18%) ⬆️
airflow/models/taskinstance.py 93.62% <0%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f14bd8...6a3b15b. Read the comment docs.

@potiuk potiuk merged commit c650df4 into apache:master Aug 7, 2019
ashb pushed a commit that referenced this pull request Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants