Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5133] Keep original env state in provide_gcp_credential_file #5747

Merged
merged 1 commit into from
Aug 14, 2019

Conversation

mik-laj
Copy link
Member

@mik-laj mik-laj commented Aug 7, 2019

Preserve the state of the environment variable after execution of provide_gcp_credential_file decorator to avoid side-effect.


Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-5133
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@mik-laj mik-laj added the provider:google Google (including GCP) related issues label Aug 7, 2019
@mik-laj mik-laj requested a review from potiuk August 7, 2019 06:37
@mik-laj mik-laj changed the title {AIRFLOW-5133] Keep original env state in provide_gcp_credential_file [AIRFLOW-5133] Keep original env state in provide_gcp_credential_file Aug 7, 2019
@mik-laj mik-laj changed the title [AIRFLOW-5133] Keep original env state in provide_gcp_credential_file [AIRFLOW-5133][depends on AIRFLOW-5130] Keep original env state in provide_gcp_credential_file Aug 7, 2019
@potiuk
Copy link
Member

potiuk commented Aug 7, 2019

Needs rebase

@mik-laj
Copy link
Member Author

mik-laj commented Aug 8, 2019

@potiuk rebased.

@mik-laj mik-laj changed the title [AIRFLOW-5133][depends on AIRFLOW-5130] Keep original env state in provide_gcp_credential_file [AIRFLOW-5133] Keep original env state in provide_gcp_credential_file Aug 12, 2019
@mik-laj mik-laj requested a review from kaxil August 12, 2019 17:22
@mik-laj mik-laj merged commit 877e42d into apache:master Aug 14, 2019
ashb pushed a commit that referenced this pull request Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants